feat(zipapp): add windows support#3561
Conversation
Summary of ChangesHello @rickeylev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request is a work-in-progress to extend the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds Windows support to the py_zipapp rules by introducing logic to create a Windows .exe launcher. The implementation in py_zipapp_rule.bzl appears solid, correctly handling platform differences and Bazel version compatibility.
However, there are significant issues with the accompanying tests that need to be addressed:
- In
tests/py_zipapp/BUILD.bazel, a necessary dependency onabsl_pyis commented out for one of the test targets. This will cause a runtime failure. - The test implementation files (
venv_zipapp_test.pyandsystem_python_zipapp_test.py) have not been updated. They contain assertions that will fail on Windows because they expect a shell script instead of a Windows executable. The tests need to be made platform-aware to properly validate this new functionality.
Fixing these test issues is critical for ensuring the Windows support is robust and verifiable.
…into pyzipapp.windows
|
@gemini-code-assist review |
There was a problem hiding this comment.
Code Review
This pull request adds Windows support for py_zipapp rules by introducing an .exe launcher. The core logic for creating the Windows launcher has been refactored from py_executable.bzl into common.bzl for better reusability. The tests for py_zipapp have been updated to be platform-agnostic and now cover the Windows case. The changes look good and are a welcome improvement. I have one suggestion to refactor a piece of duplicated logic to improve maintainability.
|
PTAL |
2 participants
This adds Windows support to the py_zipapp rules.
It works the same as what py_binary does: the Bazel builtin launcher.exe is
populated with the path to the zip, and the exe then handles starting Python
and running the zip.
This should be the last of the implementation, so all that remains is
deprecating the code in py_binary and removing it.
Work towards #2586